Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions for TCP-TLS docs #27319

Closed
wants to merge 6 commits into from
Closed

Suggestions for TCP-TLS docs #27319

wants to merge 6 commits into from

Conversation

schavis
Copy link
Contributor

@schavis schavis commented May 31, 2024 •
edited
Loading

Suggestions for #27318

@schavis schavis requested a review from a team as a code owner May 31, 2024 22:24
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 31, 2024
@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

finnigja
finnigja reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@finnigja finnigja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions but generally looks good to me!

website/content/docs/configuration/listener/tcp/index.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp/index.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp/tcp-tls.mdx Outdated Show resolved Hide resolved
@schavis schavis requested a review from a team as a code owner June 3, 2024 19:11
@schavis schavis mentioned this pull request Jun 3, 2024
Merged
@schavis
Copy link
Contributor Author

schavis commented Jun 3, 2024

Replaced with #27335

@schavis schavis closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finnigja finnigja finnigja left review comments

@jonathanfrappier jonathanfrappier jonathanfrappier approved these changes

Assignees
No one assigned
Labels
docs hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schavis @finnigja @jonathanfrappier